-
Notifications
You must be signed in to change notification settings - Fork 971
Conversation
@cezaraugusto has tested on macOS and I just tried on Windows- this works great! 😄 very very nice. Huge thanks for knocking this out so quick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on macOS, works great ++
There is a test failing after this change but I think @bsclifton have a good plan for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Only feedback I have is: this breaks a test which was depending on this being DOM selectable (via one of the webdriver tests).
Would you mark the failed tests with a .skip? Other than than, this looks great 😄 Thanks again!
for reference of #8397 (review). Link: https://github.com/brave/browser-laptop/blob/master/test/tab-components/tabTest.js#L105
|
Long term, it would be really nice to have the contextMenus.js code detect whether or not it's running in a test. If so, it could render the old way (creating a contextMenu object in React). This would be a big scale change though- for now, marking the failed test with .skip would work 😄 Now that we have a proposed solution for async menus (still needs testing / integration) with brave/muon#161, we should be able to convert all the old style menus to native context menus. Since you've already done that before (ex: the reload button and a few other places, IIRC), if you wanted to create an issue to track what needs to be converted and then also which has skipped tests (like this one), that would be awesome 😄 I'm going to try my best to dig into the Muon PR above so that we can have async native menus |
I disabled the tests. @bsclifton Great idea! I'll see what I can do. |
💯 |
@@ -102,14 +102,14 @@ describe('tab tests', function () { | |||
.click(newFrameButton) | |||
.waitForExist('[data-test-id="tab"][data-frame-key="2"]') | |||
}) | |||
it('shows a context menu when long pressed (click and hold)', function * () { | |||
it.skip('shows a context menu when long pressed (click and hold)', function * () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liunkae Was this added to the tracking ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luixxiul Thanks! Added.
Change is small- I pulled this into 0.15.0 per recommendation by @bradleyrichter |
Moving back to 0.15.1. There are some other changes which this relies on. Unfortunately, pulling in is not as easy as I thought |
Fixes #7748
git rebase -i
to squash commits (if needed).Test Plan:
Screenshot:
