Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

update urlbar value on selection change #8868

Merged
merged 1 commit into from
May 15, 2017
Merged

update urlbar value on selection change #8868

merged 1 commit into from
May 15, 2017

Conversation

bridiver
Copy link
Collaborator

fix #8865

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton added this to the 0.15.300 milestone May 15, 2017
@bbondy
Copy link
Member

bbondy commented May 15, 2017

There's still various navbar tests that are failing so not sure if this makes it worse or better for tests, but I verified it does fix the problem reported so merging.

@bbondy bbondy merged commit 1f25edb into master May 15, 2017
bbondy added a commit that referenced this pull request May 15, 2017
update urlbar value on selection change
Copy link
Collaborator

@jonathansampson jonathansampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bsclifton bsclifton deleted the issue-8865 branch May 16, 2017 05:25
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Completion Breaks Additional Input
5 participants