Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add disabled state for bookmark modal button #9321

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Add disabled state for bookmark modal button #9321

merged 1 commit into from
Jun 8, 2017

Conversation

cezaraugusto
Copy link
Contributor

Auditors: @luixxiul
Close #9019

I needed to split this out of 9d89df8 as it will be included in 0.17.x

STR:

  1. Create a folder under bookmarks toolbar
  2. Modal should show with disabled button state

screen shot 2017-06-07 at 6 01 54 pm

@cezaraugusto cezaraugusto added this to the 0.17.x (Frozen, only critical adds from here) milestone Jun 7, 2017
@cezaraugusto cezaraugusto self-assigned this Jun 7, 2017
@cezaraugusto cezaraugusto requested a review from luixxiul June 7, 2017 21:06
@srirambv srirambv mentioned this pull request Jun 8, 2017
Closed
@cezaraugusto cezaraugusto merged commit 89ed40c into brave:master Jun 8, 2017
@cezaraugusto cezaraugusto deleted the bookmarks/9019 branch June 8, 2017 01:53
luixxiul
luixxiul reviewed Jun 8, 2017
View reviewed changes
Copy link
Contributor

@luixxiul luixxiul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@luixxiul luixxiul luixxiul left review comments

Assignees

@cezaraugusto cezaraugusto

Labels
feature/bookmarks
Projects
None yet
Milestone
0.17.13 (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@cezaraugusto @luixxiul