Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

brave.crypto domain (used in IPNS test) no longer resolves #468

Closed
stephendonner opened this issue Sep 1, 2022 · 0 comments · Fixed by #469
Closed

brave.crypto domain (used in IPNS test) no longer resolves #468

stephendonner opened this issue Sep 1, 2022 · 0 comments · Fixed by #469
Assignees
@stephendonner
Labels
testsheet

Comments

@stephendonner
Copy link
Contributor

stephendonner commented Sep 1, 2022 •
edited
Loading

http://brave.crypto/ no longer resolves (brave/brave-browser#14099 added support for it via Unstoppable Domains). We're using it in this test[0]:

Verify visiting ipns://brave.crypto brings up IPFS interstitial page.
Verify selecting Use a public gate loads https://brave-crypto.ipns.dweb.link via public gateway.

Switch it to http://brad.crypto, which works (even for ipns://brad.crypto) which is what this test is intending to test 👍

Slack thread: https://bravesoftware.slack.com/archives/C01K7EDB082/p1662047043395859

[0] https://github.com/brave/qa-resources/blob/82e6e8dd508f87595b20c4bbde093cd80d124dbe/wikitemplate-IPFS.md#ipfsipns-uri

cc @srirambv
@stephendonner stephendonner self-assigned this Sep 1, 2022
stephendonner added a commit that referenced this issue Sep 1, 2022
@stephendonner
Fixes issue #468 - use brad.crypto instead of brave.crypto
44d7fb4 
Fixes #468
@stephendonner stephendonner mentioned this issue Sep 1, 2022
Merged
stephendonner added a commit that referenced this issue Sep 1, 2022
@stephendonner
Merge pull request #469 from brave/fix_468
c0c8125 
Fixes issue #468 - use brad.crypto instead of brave.crypto
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@stephendonner stephendonner

Labels
testsheet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes issue #468 - use brad.crypto instead of brave.crypto brave/qa-resources
1 participant
@stephendonner