Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update revenue_tracking.md for React Native #2036

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

solidw
Copy link
Contributor

@solidw solidw commented Apr 14, 2021

Pull Request/Issue Resolution

Description of Change:
ReactAppboy.logPurchase has different parameter type. I updated it based on appboy-react-sdk and example.

Closes #nothing

Is this change associated with a Braze feature/product release?

  • Yes (Insert Feature Release Date Here)
  • No

If yes, please note the date of the feature release.



PR Checklist
  • Check that all links work!
  • Ensure you have completed our CLA.
  • Tag @timothy-kim and @KellieHawks as a reviewer when your work is done and ready to be reviewed for merge.
  • Tag others as Reviewers as necessary.
  • If you have modified any links, be sure to add redirects to config/nginx.conf.erb.
Writing & Style Quick Tips
  • Use the formatting shown on the Styling Test Page to create unique templates and vehicles for your information.
  • Use Action verbs!
  • Capitalize proper nouns, unique Braze tools and features, custom Braze channels, and all Header titles.
  • Redirect when necessary!
  • Always speak to the Braze customer - refer to them as “you”, whether they are an Engineer/Developer, a Marketer, or an Admin.
  • On Voice: You should aim to be a Friendly Professor. Imagine, if you will, the smartest, but also kindest professor you had. You know, the one who showed you your potential and tested you, but also went slowly in class so you could take great notes and learn some things? Don't be too peppy, but don't be formal. You’re not selling anything - you’re instructing and informing and enabling.

Consult the Docs Text Formatting Guide and the Docs Writing Style Guide & Best Practices for more details.

ATTENTION: For PR Reviewers
  • Read our Reviewing a PR page for more on our reviewing suggestions.
  • Preview all changes in the linked Heroku environment (click View deployment button below, then "Docs". A 502 error just means you should refresh until you see the Docs Home page.


@cla-bot cla-bot bot added the cla-signed label Apr 14, 2021
@@ -11,7 +11,7 @@ See [the Android integration instructions][1] for in depth discussion of revenue
```javascript
var properties = {};
properties["KeyOne"] = "ValueOne";
ReactAppboy.logPurchase("testPurchaseWithNullCurrency", 10, null, 5, properties);
ReactAppboy.logPurchase("productId", "10.99", "USD", 5, properties);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logPurchase's parameter type.

export function logPurchase(
  productId: string,
  price: string,
  currencyCode: string,
  quantity: number,
  purchaseProperties?: object
): void;

@solidw
Copy link
Contributor Author

solidw commented Apr 14, 2021

Minor issue about logPurchase function in React Native document.
@timothy-kim @KellieHawks

@solidw solidw changed the title Update React Native document about logPurchase Update revenue_tracking.md for React Native Apr 14, 2021
@KellieHawks KellieHawks self-requested a review April 14, 2021 14:15
Copy link
Contributor

@KellieHawks KellieHawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KellieHawks KellieHawks merged commit 628d1bb into braze-inc:develop Apr 14, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants