Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Images carousel in station info panel #181

Merged
merged 16 commits into from
Feb 24, 2025

Conversation

dcapslock
Copy link
Contributor

As per discussion #173. Now includes examples which are globally relevant.

@mKainzbauer
Copy link
Collaborator

Do we need

#if not 'Images' in $StationInfo
#stop
#end if

in https://github.com/brewster76/fuzzy-archer/pull/181/files#diff-1902e9ab62fde987aaca37df5b36d54e23bfeeafe105720dac4c7e4635228167?

While I am quite sure it won't really harm, the file is not being included, when Images is not in [StationInfo] in the first place, see https://github.com/brewster76/fuzzy-archer/blob/master/skins/Bootstrap/livegauges.html.inc:

#for $station_info_item in $station_info_items
        #include $station_info_item + ".html.inc"
        #end for

I'd prefer not to check for the [[Images]] in [StationInfo], since you get an error message, if images is in station_info_items, and [[Images]] is missing, but if you remove [[Images]] and leave images in station_info_items, it will be just ignored silently, leaving a "dead" configuration item in station_info_items, which may lead to config confusion in certain cases. But maybe I am missing the point.

@dcapslock
Copy link
Contributor Author

Agree, check is not needed. I have removed. Thanks

@mKainzbauer mKainzbauer merged commit 2912bb7 into brewster76:master Feb 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants