Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Macros typos on windows platform in wave.h #13

Closed
Xtinc opened this issue Jul 24, 2024 · 2 comments
Closed

Macros typos on windows platform in wave.h #13

Xtinc opened this issue Jul 24, 2024 · 2 comments

Comments

@Xtinc
Copy link

Xtinc commented Jul 24, 2024

in wave.h file, line 34-37,
a type mistake happenned which made Macro

#if defined(_MSC_VER)
#define WAVE_API __declspec(dllexport)
#else

to

#if defined(_MSV_VER)
#define WAVE_API __declspec(dllexport)
#else

it seems that MSC_VER was misspelled as MSV_VER, cause a compiler error on windwos
@Xtinc
Copy link
Author

Xtinc commented Jul 24, 2024

This lib does a small but nice work.
another suggest is the macro which detects BIG-ENDIAN or LITTLE-ENDIAN was also broken on windows

brglng added a commit that referenced this issue Jul 24, 2024
@brglng
fix(windows)!: fix preprocessor testing on Windows (#13)
8dfc2fe
brglng added a commit that referenced this issue Jul 24, 2024
@brglng
fix(endian): fix endian testing (#13)
72bbb7b
@brglng
Copy link
Owner

brglng commented Jul 24, 2024

Fixed in 72bbb7b.

@brglng brglng closed this as completed Jul 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brglng @Xtinc