Improve slow monitor performance #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where slow StateMonitor clocks incurred state pull operations on every tick. Additionally, operations across StateMonitor and run_regularly operations are consolidated, reducing transfers to the minimum necessary.
Instead of pulling the entire state of a particular model, we can just pull the individual variables requested by each StateMonitor / run_regularly operation.
mstimberg
requested changes
Apr 7, 2022
There was a problem hiding this comment.
Sorry for the late review. This looks great! I only recently realized that Brian2GeNN is pulling all the variables when using a StateMonitor – this is a nice improvement. I made two minor comments. Let me know if you don't have the time to take them into account, I can also fix these details myself.
|
Done. Test failures seem to point to a bug revealed by brian-team/brian2@aff91cb outside of the scope of this PR, I believe. |
mstimberg
approved these changes
Apr 11, 2022
Yes, the failures do not seem to have anything to do with this PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my previous pull request (#140) I introduced support for slower clocks for StateMonitor objects, but failed to notice that the necessary data transfers are not rolled into the code objects, but are rather processed (somewhat) parsimoniously in the engine template.
This pull request expands on the general principle of minimizing unnecessary transfers in the following ways:
StateMonitors are only transferred in the required iterations, rather than at every tick as beforeStateMonitorandrun_regularlyoperations, including both'start'and'end'slots for SMsSince this was a little too much to ask of Jinja, I've placed the consolidation logic into device.py, providing the template with the names of the variables to be pulled, along with their periods.