when using babel, pg-native is always required (and fails if not present)

[nahuel]

I'm not sure if this is a Babel or a node-postgres bug, steps to reproduce:

export PATH=$PATH:/tmp/iojs-v3.0.0-linux-x64/bin/:./node_modules/.bin
mkdir t
cd t
npm install babel pg

# create a t.js file with this ES6 content:
import * as pg from "pg";
console.log(pg);

# now execute: 
babel t.js > t-es5.js
node t-es5.js 

Error: Cannot find module 'pg-native'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/tmp/o/node_modules/pg/lib/native/index.js:1:76)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

Babel generates the following code in t-es5.js:

function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key]; } } newObj["default"] = obj; return newObj; } }

var _pg = require("pg");

var pg = _interopRequireWildcard(_pg);

console.log(pg);

The exception is happening in the _interopRequireWildcard(_pg) call. This doesn't happens with other libraries, so I'm not sure if a Babel or a node-postgres bug.

[olegsmetanin]

+1 using webpack + babel + typescript
ERROR in .//pg/lib/native/index.js
Module not found: Error: Cannot resolve module 'pg-native' in /Volumes/DATA/SOA/2015/github/typescript_babel_react_express_dev/node_modules/pg/lib/native
@ .//pg/lib/native/index.js 1:13-33

[olegsmetanin]

comment this lines in node_modules/pg/lib/index.js
if(typeof process.env.NODE_PG_FORCE_NATIVE != 'undefined') {
//module.exports = new PG(require('./native'));
} else {
module.exports = new PG(Client);

//lazy require native module...the native module may not have installed
// module.exports.defineGetter("native", function() {
// delete module.exports.native;
// module.exports.native = new PG(require('./native'));
// return module.exports.native;
// });
}

[artem1]

pg define getter in module.exports
https://github.com/brianc/node-postgres/blob/master/lib/index.js#L76

  //lazy require native module...the native module may not have installed
  module.exports.__defineGetter__("native", function() {
    delete module.exports.native;
    module.exports.native = new PG(require('./native'));
    return module.exports.native;
  });

when babel rewrite code, him not found __esModule property in module and make copy of module props to new hash. in copy process pg.native called unintentionally. has no idea, how to fix this

function _interopRequireWildcard(obj) { //obj is pg module
  if (obj && obj.__esModule) {  //<===== test to something
    return obj; 
  } else { 
    var newObj = {}; 
    if (obj != null) { 
      for (var key in obj) { 
        if (Object.prototype.hasOwnProperty.call(obj, key)) 
          newObj[key] = obj[key];  //<== call getter here
      } 
    } 
    newObj["default"] = obj; 
    return newObj; 
  } 
}

[thaumant]

This might help you:

import pg from 'pg'

[jmont]

Any progress with this issue?

[langpavel]

I'm not experiencing this issue. I also using import pg from 'pg'. This can be solution I think.

[nybble73]

import pg from 'pg' does not work for me - I am seeing the pg-native error.

[langpavel]

@nybble73 What code generates babel for `import pg from 'pg'? Which versions?

This issue can be fixed only by wrapping pg.native getter to try/catch.

[langpavel]

@brianc Should I prepare pull request?

My suggestion is return null if require('pg-native') fail

Another option is return this itself and write once an error to stdout

[brianc]

sure thing - pull request always welcome!

On Wed, Feb 24, 2016 at 3:08 PM, Pavel Lang notifications@github.com
wrote:

@brianc https://github.com/brianc Should I prepare pull request? My
suggestion is return null if require('pg-native') fail

—
Reply to this email directly or view it on GitHub
#838 (comment)
.

[swarajgiri]

Still facing the same issue on "pg": "^6.1.5".

[catamphetamine]

I'm too facing it, using Webpack and AWS Lambda.
This comment workaround worked (just the alias/pg-native.js part):
serverless-heaven/serverless-webpack#78 (comment)