Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Units.php #2724

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update Units.php #2724

wants to merge 3 commits into from

Conversation

yarscript
Copy link

@kylekatarnls
Copy link
Collaborator

Hello because of this:
#2723 (comment)

We shouldn't make any explicit cast here, or else we should add first an input validation with a specific error such as "string" is not a valid numeric value.

Because muting the error and simply replacing any non-numeric string with 0 is just hiding to the developer the incorrect usage and cause bugs later.

@kylekatarnls kylekatarnls marked this pull request as draft December 16, 2022 12:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants