Replace P-256 arithmetic with BoringSSL's P-256 arithmetic. #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansmith
force-pushed
the
b/use-boringssl-p256
branch
5 times, most recently
from
1874cbb to
b058727
Compare
briansmith
changed the title
briansmith
force-pushed
the
b/use-boringssl-p256
branch
from
b058727 to
368e35c
Compare
briansmith
force-pushed
the
b/use-boringssl-p256
branch
3 times, most recently
from
87048ad to
5c60c43
Compare
briansmith
force-pushed
the
b/use-boringssl-p256
branch
from
5c60c43 to
94b542a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 92.22% 93.56% +1.34%
==========================================
Files 106 111 +5
Lines 14232 17337 +3105
==========================================
+ Hits 13125 16221 +3096
- Misses 1107 1116 +9
Continue to review full report at Codecov.
|
Don't require a specialized implementation of field element addition for each curve; instead share an implementation between RSA and ECC. Refactor the code to avoid needing `elem_sum`.
Use Fiat Crypto for non-x86_64 platforms, like BoringSSL. Continue using the nistz256 code on Windows, differently from BoringSSL. Make *ring* more consistent with BoringSSL.
briansmith
force-pushed
the
b/use-boringssl-p256
branch
from
94b542a to
415dee1
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Fiat Crypto for non-x86_64 platforms, like BoringSSL. Continue using the nistz256 code on Windows, differently from BoringSSL.
Make ring more consistent with BoringSSL.