-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
spotify play --playlist #27
Comments
Is anyone working on the playing of a playlist? Also curious as to see if there is the possibility of implementing the ability to see the 'Liked songs' playlist (I use that for my spotify usage. |
Created an issue for playing the "Liked Songs" playlist! 😄 Although, this issue has to be completed first. Let me know if you're interested in working on it and I'll assign it to you. @Threpio |
Was having a look at the codebase whilst I was curious - Not 100% sure I know how to apply it straight up. The generic Spotify libraries don't seem to support referencing a playlist as a command/variable. |
I didn't realise that you were referencing your own Spotify go api library. Do we need to create the 'play playlist' functionality there and then update the reference/commands here? Sorry for the time |
@Threpio No worries, the only change you'd have to implement in the library is searching by playlist/album (which should be relatively simple; just a few lines of code). It currently hardcodes "track" in the search parameters: https://github.com/brianstrauch/spotify/blob/5e406af4be1b0cc7d6fb0cdec0288bb09013d77c/search.go#L13 |
A first stab at the changes to the spotify library - This could then be called in here. I think I was just going to reference the 'GetPlaylist' Function that had already been created?
EDIT: I have realised that this only returns playlists of the user - I assume other playlists being played will be needed aswell. |
@Threpio Actually... I think we can just use the existing |
the GetPlaylist function returns a Playlist object - Which I believe contains the URI?
|
@Threpio Hmm... I was originally thinking we could give people the option to play any playlist, but being able to play only your own playlists is probably better for UX. In that case, we should call the So, the good news is that we won't have to implement anything new in the SDK, just the CLI. 😄 |
Although the |
--Album can be for a future PR. I won't be able to do this this evening but am happy to look at it this weekend :) Edit: Do we want this as a flag on play or |
@Threpio Commented on your PR, but we can add |
…/spotify-cli into playlist-brianstrauch#27 # Conflicts: # internal/p/p.go
…/Threpio/spotify-cli into playlist-brianstrauch#27" This reverts commit 6fdf6dd, reversing changes made to bdabdb5.
* Tests broken but playlist functionality added * Fixed tests but need to make new tests for 'play-playlist' * Update internal/play/play_test.go Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Update internal/p/p_test.go Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Syntax updates to mock_api.go Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Added switch case to play functions and adapted to queryType - Requires PR on spotify * Rename errors as per suggestion Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Fixing Tests Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Fixing Tests Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Fixing Tests Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Syntax cleanup Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Syntax cleanup Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Fixing Tests Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Fixing command flags as per suggestion Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Update internal/p/p_test.go Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Syntax Updates Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Update internal/errors.go Co-authored-by: Brian Strauch <bstrauch24@gmail.com> * Updated p to better reflect play * Revert "Merge branch 'playlist-#27' of https://github.com/Threpio/spotify-cli into playlist-#27" This reverts commit 6fdf6dd, reversing changes made to bdabdb5. * updated to 0.7.0 -> Failed with some merging so git is messy * Sorted out errors again * More sorting out of play functions * Running go fmt * Forgot contextQuery Logic for p() function Co-authored-by: Brian Strauch <bstrauch24@gmail.com>
No description provided.
The text was updated successfully, but these errors were encountered: