Text Highlighter Update #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems simple enough. Ill get it merged in. |
|
Hello @brianvoe! Thanks for the amazing component. We just hit this issue, would you be willing to cut a new release. 🙏 |
|
im trying |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I noticed a regression when finally getting around to updating to v2. Essentially, it's a repeat of this issue
I haven't worked with typescript projects before so I'm sorry if my PR doesn't contain all of the necessary updates in order for this to be merged (I'm not sure if there is a build step that compiles the typescript to javascript, or if I have to do that myself). But, in my testing, it just required a simple regex change in order to ensure only text inside of html elements are matched, and not their respective attributes.
Happy to clean this up in whichever way it needs to