Allow key presses not relevant to SlimSelect to propagate to default handlers #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the main div has focus, it soaks up all
onkeydown
events. Those it recognizes (arrow keys, tab, space, enter, etc) are dispatched to its event handlers, but all unrecognized key events are dropped and prevented from propagating.This means, while the select box has focus:
Instead, all these standard keyboard shortcuts have no effect until the main div is unfocused, which is pretty confusing and annoying behavior. Accessibility issues aside, as a user, if the last thing I did was select an option from a slim-select, my "reload page" keyboard shortcut appears broken for no obvious reason.
This small change from
return false
toreturn true
lets keyboard events bubble up to their default browser handlers.Note: I'm on OSX and have tried Firefox and Chrome with identical results. Other browsers or operating systems may do a better job at disallowing in-page event handlers from blocking fundamental features like "Reload".
Just noticed this fixes #526I misinterpreted that issue, this PR does not fix it.