Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v2/images: remove source and add URL parameter #40

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

tormath1
Copy link
Contributor

The source option was tied to the FTP based workflow which is no longer supported. Thus the option would trigger an unresolvable error for the SDK user.

(From: brightbox/brightbox-cli@10cb209)


Locally tested with:

img, err := client.CreateImage(ctx, brightbox.ImageOptions{
	Arch:              arch.X86_64,
	Name:              &name,
	Username:          &username,
	MinRAM:            &ram,
	URL:               "https://...flatcar_production_openstack_image.img",
	Public:            &public,
	CompatibilityMode: &compatibilityMode,
})
if err != nil {
	log.Fatal(err)
}

fmt.Println(img)

The `source` option was tied to the FTP based workflow which is no
longer supported. Thus the option would trigger an unresolvable error
for the SDK user.

(From: brightbox/brightbox-cli@10cb209)

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@NeilW NeilW merged commit 9ba208e into brightbox:master Nov 14, 2023
@NeilW
Copy link
Member

NeilW commented Nov 14, 2023

Thanks. Tagged that as v2.2.0

@tormath1 tormath1 deleted the tormath1/create-image-v2 branch November 14, 2023 15:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants