Bump default timeouts #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although in the steady state 10 second timeout is reasonable, in practice p100 was observed to be much higher than that (if, for example, the machine you are supposed to talk to needs to cold boot). Given that just _one_ timeout terminates the entire process, it feels like we can benefit from being quiet a bit more conservative here for the time being.
kylewlacy
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
👍 I like this
>=60 second requests is not ideal, but I'd prefer to have builds work at all (even if slow) instead of being flaky while waiting for a cold start. Hopefully over time, I can get Brioche's infrastructure to a point where cold start times aren't so brutal, either by just running some instances continually or by speeding them up somehow
|
(Oh, and I always forget that you need |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although in the steady state 10 second timeout is reasonable, in practice p100 was observed to be much higher than that (if, for example, the machine you are supposed to talk to needs to cold boot).
Given that just one timeout terminates the entire process, it feels like we can benefit from being quiet a bit more conservative here for the time being.