Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add the ability to format more than one project at a time. #84

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

jaudiger
Copy link
Contributor

Add the ability to format more than one project at a time by authorizing the usage of multiple -p arguments.

Part of #75

Signed-off-by: jaudiger <jeremy.audiger@ioterop.com>
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I did find one thing that could be improved: if you run brioche fmt --check -p project1 -p project2 and both projects have formatting issues, then only the files for one of the projects will get printed

But I also don't feel that this is a blocker, I'm fine merging this as-is and handling that as a future issue or follow-up

@jaudiger
Copy link
Contributor Author

Thank you, I'll do that in a follow-up. I always prefer to reduce the scope of my PRs. To reduce the review burden, the regression's scope, etc. At the end there are more PRs opened, but that's my trade-off

@kylewlacy kylewlacy merged commit 7647182 into brioche-dev:main Jul 12, 2024
5 checks passed
@jaudiger jaudiger deleted the format-multiple-projects branch July 13, 2024 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants