-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Migrate Cypress files to be compatible with v.13 #485
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Using `npx cypres open 2. Follow the instructions Changes in this commit are all made by the migration Wizard Note: Changes here caused all tests to fail. I'm commiting this independent;y to isolate changes made by the wizard from changes I will need to make to fix the problem
- Remove the old faker package ( https://www.npmjs.com/package/faker ) - Install new faker package ( https://www.npmjs.com/package/@faker-js/faker )
- Use @import - Updte only the english version to reduce bundle size - Update places on ode where we call faker
While we don't find a better way to authenticate when the login is just a test precondition.
Testing drag and drop is too complex.
a05c85c
to
83c2ee4
Compare
wlsf82
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 🍰
I especially loved the README.md
updates.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
npx cypress open
faker
package from the abandoned package to currently maintained @faker-js/faker@import
faker in test files