Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate Cypress files to be compatible with v.13 #485

Merged
merged 14 commits into from
Nov 13, 2023

Conversation

idmarjr
Copy link
Collaborator

@idmarjr idmarjr commented Nov 12, 2023

Summary

  • Update Cypress files with help of updater wizard: npx cypress open
  • Change faker package from the abandoned package to currently maintained @faker-js/faker
  • Update the way we @import faker in test files
  • Temporarily replace login via API by login via GUI in all tests
br-modelo-green-tests

1. Using `npx cypres open
2. Follow the instructions

Changes in this commit are all made by the migration Wizard

Note: Changes here caused all tests to fail. I'm commiting this
independent;y to isolate changes made by the wizard from changes
I will need to make to fix the problem
- Remove the old faker package ( https://www.npmjs.com/package/faker )
- Install new faker package (
  https://www.npmjs.com/package/@faker-js/faker )
- Use @import
- Updte only the english version to reduce bundle size
- Update places on ode where we call faker
@idmarjr idmarjr marked this pull request as draft November 12, 2023 16:51
@wlsf82 wlsf82 force-pushed the migrate-cypress-files-to-v13 branch from a05c85c to 83c2ee4 Compare November 12, 2023 23:33
@idmarjr idmarjr marked this pull request as ready for review November 13, 2023 22:47
@idmarjr idmarjr requested review from miltonbsn and wlsf82 November 13, 2023 22:48
Copy link
Collaborator

@wlsf82 wlsf82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🍰

I especially loved the README.md updates.

@idmarjr idmarjr merged commit 7b4a61f into main Nov 13, 2023
@idmarjr idmarjr deleted the migrate-cypress-files-to-v13 branch November 13, 2023 23:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants