Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DSM-commented-out-unreliable-assertion #2023

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

GiCharkviani
Copy link
Contributor

@GiCharkviani GiCharkviani commented Feb 21, 2023

I have found two things that are worth attention:

  1. the test-results.xml file is overwritten by the most recent job if two or more of them are running, which causes a wrong report from the ARTIFACTS section (CircleCi)
  2. something happens on CircleCi VM (Linux x86_64) which causes from time-to-time JS to generate the wrong date (1382486400000 -> Wed Oct 23 2013 04:00:00 GMT+0400 (Georgia Standard Time)) from the new Date().getTime() function (The reason why the Submission manager unit test fails)

Here is the solution for the failing test (2):
It would be better to remove the test based on the new Date() class (that fails occasionally).

It seems the JS Date class is not always predictable:
Dates in JavaScript are Broken. Who Shall Fix them
Inconsistent Date.prototype.getTime() value across different Node.js versions
Mocking Date.now() doesn't work on CircleCI

Failed test (CircleCi) - Please check the tmp/junit/test-results.xml file, where you can search for "START_TIME" and "END_TIME" and check that they both equal to - > 1382486400000

Copy link
Contributor

@aweng98 aweng98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aweng98 aweng98 marked this pull request as ready for review February 21, 2023 14:32
@GiCharkviani GiCharkviani merged commit 509cdb9 into develop Feb 21, 2023
@GiCharkviani GiCharkviani deleted the DSM-commented-out-unreliable-assertion branch February 21, 2023 14:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants