Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Test for presence of ack result message and simplify ProcessControllerAckResult API #7816

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

cmnbroad
Copy link
Collaborator

Fixes NPE reported in #7811.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #7816 (69be797) into master (9ae1fd8) will decrease coverage by 37.291%.
The diff coverage is 15.385%.

❗ Current head 69be797 differs from pull request most recent head c7832fb. Consider uploading reports for the commit c7832fb to get more accurate results

@@               Coverage Diff                @@
##              master     #7816        +/-   ##
================================================
- Coverage     86.954%   49.663%   -37.291%     
+ Complexity     36897     26502     -10395     
================================================
  Files           2214      2212         -2     
  Lines         173540    173384       -156     
  Branches       18736     18710        -26     
================================================
- Hits          150900     86108     -64792     
- Misses         16037     81594     +65557     
+ Partials        6603      5682       -921     
Impacted Files Coverage Δ
...ls/runtime/ProcessControllerAckResultUnitTest.java 9.091% <9.091%> (ø)
...nder/utils/runtime/ProcessControllerAckResult.java 94.737% <50.000%> (+8.373%) ⬆️
...titute/hellbender/utils/UnvalidatingGenomeLoc.java 0.000% <0.000%> (-100.000%) ⬇️
...itute/hellbender/utils/locusiterator/LIBSTest.java 0.000% <0.000%> (-100.000%) ⬇️
...ellbender/engine/AlignmentAndReferenceContext.java 0.000% <0.000%> (-100.000%) ⬇️
...ools/copynumber/models/CopyRatioSimulatedData.java 0.000% <0.000%> (-100.000%) ⬇️
...ols/walkers/mutect/clustering/BinomialCluster.java 0.000% <0.000%> (-100.000%) ⬇️
...copynumber/models/AlleleFractionSimulatedData.java 0.000% <0.000%> (-100.000%) ⬇️
...otypecaller/DragstrPairHMMInputScoreImputator.java 0.000% <0.000%> (-100.000%) ⬇️
...urces/gencode/DataProviderForMuc16MnpFullData.java 0.000% <0.000%> (-99.952%) ⬇️
... and 690 more

@cmnbroad cmnbroad marked this pull request as ready for review May 2, 2022 14:04
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmnbroad This looks good to me.

@lbergelson lbergelson merged commit 7f40444 into master Dec 23, 2022
@lbergelson lbergelson deleted the cn_ack_result branch December 23, 2022 20:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants