Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade htsjdk to v3.0.0. #7867

Merged
merged 6 commits into from
Jul 18, 2022
Merged

Upgrade htsjdk to v3.0.0. #7867

merged 6 commits into from
Jul 18, 2022

Conversation

cmnbroad
Copy link
Collaborator

No description provided.

@cmnbroad cmnbroad force-pushed the cn_update_htsjdk branch from ab032be to 55fb2d0 Compare May 24, 2022 13:13
@gatk-bot
Copy link

gatk-bot commented May 24, 2022

Github actions tests reported job failures from actions build 2378038203
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 2378038203.13 logs
integration 11 2378038203.12 logs
unit 8 2378038203.1 logs
integration 8 2378038203.0 logs

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #7867 (aa45aa8) into master (804d1e2) will increase coverage by 0.011%.
The diff coverage is 80.000%.

@@               Coverage Diff               @@
##              master     #7867       +/-   ##
===============================================
+ Coverage     87.078%   87.089%   +0.011%     
+ Complexity     36997     36993        -4     
===============================================
  Files           2217      2217               
  Lines         173849    173847        -2     
  Branches       18791     18791               
===============================================
+ Hits          151385    151402       +17     
+ Misses         15832     15818       -14     
+ Partials        6632      6627        -5     
Impacted Files Coverage Δ
...bender/tools/funcotator/StrandCorrectedAllele.java 0.000% <ø> (ø)
...nstitute/hellbender/utils/haplotype/Haplotype.java 90.244% <ø> (ø)
...kers/haplotypecaller/AssemblyBasedCallerUtils.java 90.517% <66.667%> (-0.041%) ⬇️
...itute/hellbender/engine/spark/GATKRegistrator.java 100.000% <100.000%> (ø)
...lbender/tools/sv/cluster/CanonicalSVCollapser.java 87.471% <0.000%> (-0.464%) ⬇️
...itute/hellbender/tools/LocalAssemblerUnitTest.java 92.448% <0.000%> (ø)
.../hellbender/utils/genotyper/AlleleLikelihoods.java 90.349% <0.000%> (+0.205%) ⬆️
...lbender/utils/variant/GATKVariantContextUtils.java 87.224% <0.000%> (+0.232%) ⬆️
...llbender/tools/spark/sv/evidence/ReadMetadata.java 88.480% <0.000%> (+0.245%) ⬆️
...er/tools/spark/sv/evidence/BreakpointEvidence.java 79.206% <0.000%> (+0.467%) ⬆️
... and 12 more

@gatk-bot
Copy link

Github actions tests reported job failures from actions build 2378939111
Failures in the following jobs:

Test Type JDK Job ID Logs
cloud 8 2378939111.10 logs

@cmnbroad cmnbroad force-pushed the cn_update_htsjdk branch 2 times, most recently from 9422664 to c8aca92 Compare June 7, 2022 12:18
@cmnbroad cmnbroad changed the title DRAFT: Changes for htsjdk update. Upgrade htsjdk to v3.0.0. Jun 7, 2022
@cmnbroad cmnbroad marked this pull request as ready for review June 7, 2022 12:23
@cmnbroad cmnbroad marked this pull request as draft June 7, 2022 12:25
@cmnbroad
Copy link
Collaborator Author

cmnbroad commented Jun 7, 2022

Draft until we have a Picard release with broadinstitute/picard#1812.

@cmnbroad cmnbroad force-pushed the cn_update_htsjdk branch 3 times, most recently from 08906d4 to 14b8624 Compare June 13, 2022 21:56
@droazen
Copy link
Contributor

droazen commented Jun 14, 2022

@cmnbroad Is this one ready for review?

@cmnbroad cmnbroad marked this pull request as ready for review June 14, 2022 16:19
@cmnbroad
Copy link
Collaborator Author

@droazen Yeah, I had just forgotten to take it out of draft after the Picard update.

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Merge when ready @cmnbroad

@cmnbroad cmnbroad merged commit ace7821 into master Jul 18, 2022
@cmnbroad cmnbroad deleted the cn_update_htsjdk branch July 18, 2022 20:34
jamesemery added a commit that referenced this pull request Jul 21, 2022
This reverts commit ace7821. This is a necessary step in order for #7876 to be merged
jamesemery added a commit that referenced this pull request Jul 22, 2022
This reverts commit ace7821. This is a necessary step in order for #7876 to be merged
lbergelson added a commit that referenced this pull request Sep 19, 2022
lbergelson added a commit that referenced this pull request Sep 19, 2022
This upgrades htsjdk to v3.0.0 which was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.
lbergelson added a commit that referenced this pull request Oct 12, 2022
This upgrades htsjdk to v3.0.0 which was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.
lbergelson added a commit that referenced this pull request Oct 12, 2022
This upgrades htsjdk h was attempted in #7867 and then reverted in #7960
in order to unblock the jukebox merge.

* upgrade htsjdk 2.24.1 -> 3.0.1
* upgrade picard 2.27.1 -> 2.27.5

Co-authored-by: David Roazen <droazen@broadinstitute.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants