Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added a slightly more helpful error message to the reads filter #7947

Merged
merged 2 commits into from
Dec 23, 2022

Conversation

jamesemery
Copy link
Collaborator

Fixes #7944

@jamesemery jamesemery requested a review from droazen July 15, 2022 20:13
@gatk-bot
Copy link

gatk-bot commented Jul 15, 2022

Github actions tests reported job failures from actions build 2679127706
Failures in the following jobs:

Test Type JDK Job ID Logs
unit 11 2679127706.13 logs
unit 8 2679127706.1 logs

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #7947 (413983a) into master (e81a361) will decrease coverage by 40.864%.
The diff coverage is 100.000%.

❗ Current head 413983a differs from pull request most recent head 7791882. Consider uploading reports for the commit 7791882 to get more accurate results

@@               Coverage Diff                @@
##              master     #7947        +/-   ##
================================================
- Coverage     86.981%   46.116%   -40.864%     
+ Complexity     36962     24011     -12951     
================================================
  Files           2221      2217         -4     
  Lines         173894    173851        -43     
  Branches       18785     18792         +7     
================================================
- Hits          151254     80174     -71080     
- Misses         15998     87790     +71792     
+ Partials        6642      5887       -755     
Impacted Files Coverage Δ
.../hellbender/engine/filters/CountingReadFilter.java 60.215% <100.000%> (-39.785%) ⬇️
...broadinstitute/hellbender/utils/svd/SimpleSVD.java 0.000% <0.000%> (-100.000%) ⬇️
...titute/hellbender/utils/UnvalidatingGenomeLoc.java 0.000% <0.000%> (-100.000%) ⬇️
...itute/hellbender/utils/locusiterator/LIBSTest.java 0.000% <0.000%> (-100.000%) ⬇️
...ute/hellbender/tools/htsgetreader/HtsgetClass.java 0.000% <0.000%> (-100.000%) ⬇️
...te/hellbender/tools/htsgetreader/HtsgetFormat.java 0.000% <0.000%> (-100.000%) ⬇️
...ender/utils/svd/ApacheSingularValueDecomposer.java 0.000% <0.000%> (-100.000%) ⬇️
...ender/utils/svd/OjAlgoSingularValueDecomposer.java 0.000% <0.000%> (-100.000%) ⬇️
...nder/utils/downsampling/FractionalDownsampler.java 0.000% <0.000%> (-100.000%) ⬇️
...der/cmdline/programgroups/ExampleProgramGroup.java 0.000% <0.000%> (-100.000%) ⬇️
... and 1144 more

@jamesemery
Copy link
Collaborator Author

@droazen I fixed the tests. Can you take a look? I know you have opinions

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesemery 👍 good idea.

@lbergelson lbergelson merged commit 640d921 into master Dec 23, 2022
@lbergelson lbergelson deleted the je_totalReadsInFilterMessage branch December 23, 2022 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HaplotypeCaller read filter status indicator should include the number of un-filtered reads for comparison
3 participants