Picard modifications to support flow based sequencing #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasoifer
force-pushed
the
ultima.flow.mods.squash
branch
from
bbbc6ed to
50b004b
Compare
|
retest this please |
Thanks! It seems to be working now :) |
yfarjoun
approved these changes
Jun 7, 2022
src/main/java/picard/sam/markduplicates/MarkDuplicatesForFlowHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/picard/sam/markduplicates/MarkDuplicatesForFlowHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/picard/sam/markduplicates/MarkDuplicatesForFlowHelper.java
Outdated
Show resolved
Hide resolved
|
@ilyasoifer if you can bring your branch up-to-date with picard master (and address Yossi's code review comments) I'll get this merged and released. |
ilyasoifer
force-pushed
the
ultima.flow.mods.squash
branch
from
ba747da to
89f425b
Compare
|
retest this please |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifications to QualityYieldMetrics and to MarkDuplicates that are needed to support the flow based sequencing
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests