Remove unused method Fingerprint.filterSuspectSites() #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
suggested changes
Jan 12, 2023
| * Attempts to filter out haplotypes that may have suspect genotyping by removing haplotypes that reach | ||
| * a minimum confidence score yet have a significant fraction of observations from a third or fourth allele. | ||
| */ | ||
| public void filterSuspectSites() { |
There was a problem hiding this comment.
Have you checked usages of this in picard-private? Perhaps @yfarjoun could comment on whether this method is likely to be in use / useful?
There was a problem hiding this comment.
@droazen I can't find any uses of it in picardPrivate or the entirety of public github. It was last touched in 2016 by Eric.
droazen
approved these changes
Mar 21, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deleting an unused and untested method that was last modified in 2016. Noticed this when rebasing #1826
I'm under the impression that picard doesn't intend to act as a stable api for downstream projects so we're free to delete locally unused public methods?
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests