Enable IntelInflater #1885
Merged
Enable IntelInflater #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We have been using the Java Inflater even when the Intel one was available and requested due to a bug in the configuration of the default inflater. The fix is fairly brittle because it depends on the order of initialization of various things. * This will be fixed more generally by samtools/htsjdk#1666
droazen
approved these changes
Jun 2, 2023
|
@lbergelson Can you confirm that the test you added fails without your patch? |
|
@droazen Yes, I tested without my patch and the inflater test fails. The deflater one passes because it was working before my patch. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long standing bug where we were accidentally not using the intel inflator when decompressing even when it was requested. Includes a horrible test using brittle reflection.