Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support srcDir with leading slash #128

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Support srcDir with leading slash #128

merged 1 commit into from
Apr 8, 2020

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Apr 4, 2020 •
edited
Loading

For #127

@rwjblue rwjblue merged commit def529f into broccolijs:master Apr 8, 2020
@Gaurav0 Gaurav0 deleted the srcDir_slash branch April 8, 2020 21:37
stefanpenner
stefanpenner reviewed Apr 9, 2020
View reviewed changes
Copy link
Contributor

@stefanpenner stefanpenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input seems odd, should we consider throwing?

@Gaurav0
Copy link
Contributor Author

Gaurav0 commented Apr 9, 2020

@stefanpenner We could, but that is still a breaking change from 2.x. As I said in the issue, if we want to make a breaking change, we should document it, otherwise keep the same behavior.

@Gaurav0 Gaurav0 mentioned this pull request Apr 9, 2020
Closed
@rwjblue rwjblue changed the title support srcDir with leading slash Support srcDir with leading slash May 9, 2020
@rwjblue rwjblue added the bug label May 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stefanpenner stefanpenner stefanpenner left review comments

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gaurav0 @stefanpenner @rwjblue