Stop gathering instantiation stack manually. #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added waaaaaay back in 46e1e23 (2014), long before the newer `broccoli-plugin` APIs (around Broccoli@1) started creating an instantiation stack to be used for error handling across the board. Now that we extend from broccoli-plugin directly, we no longer have to do this manually. Additionally, the code in broccoli-plugin is authored such that it avoids touching the `.stack` property unless it is actually needed (forcing V8 to create the stack is costly).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added waaaaaay back in 46e1e23 (2014), long before the newer
broccoli-pluginAPIs (around Broccoli@1) started creating an instantiation stack to be used for error handling across the board.Now that we extend from broccoli-plugin directly, we no longer have to do this manually. Additionally, the code in broccoli-plugin is authored such that it avoids touching the
.stackproperty unless it is actually needed (forcing V8 to create the stack is costly).Thanks to @krisselden for pointing this out.