Skip to content

Commit

Permalink
Stub telemetry calls during all tests (apache#327)
Browse files Browse the repository at this point in the history 
This change makes _all_ `describe` blocks in cli.spec descendants of a
common top-level `describe` block which stubs any critical telemetry
methods.

Thus we ensure that telemetry is never collected during test runs.
  • Loading branch information
@raphinesse
raphinesse authored Sep 16, 2018
1 parent 20af4ec commit f8ed27c
Showing 1 changed file with 108 additions and 108 deletions.
216 changes: 108 additions & 108 deletions spec/cli.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -360,141 +360,141 @@ describe('cordova cli', () => {
});
});
});
});

describe('platform', () => {
describe('platform', () => {

beforeEach(() => {
spyOn(cordova, 'platform').and.returnValue(Promise.resolve());
logger.setLevel('error');
});
beforeEach(() => {
spyOn(cordova, 'platform').and.returnValue(Promise.resolve());
logger.setLevel('error');
});

it('Test #034 : (add) autosave is the default setting for platform add', () => {
return cli(['node', 'cordova', 'platform', 'add', 'ios']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'add',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(true);
it('Test #034 : (add) autosave is the default setting for platform add', () => {
return cli(['node', 'cordova', 'platform', 'add', 'ios']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'add',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(true);
});
});
});

it('Test #035 : (add) platform is not saved when --nosave is passed in', () => {
return cli(['node', 'cordova', 'platform', 'add', 'ios', '--nosave']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'add',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(false);
it('Test #035 : (add) platform is not saved when --nosave is passed in', () => {
return cli(['node', 'cordova', 'platform', 'add', 'ios', '--nosave']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'add',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(false);
});
});
});

it('Test #036 : (remove) autosave is the default setting for platform remove', () => {
return cli(['node', 'cordova', 'platform', 'remove', 'ios']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'remove',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(true);
it('Test #036 : (remove) autosave is the default setting for platform remove', () => {
return cli(['node', 'cordova', 'platform', 'remove', 'ios']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'remove',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(true);
});
});
});

it('Test #037 : (remove) platform is not removed when --nosave is passed in', () => {
return cli(['node', 'cordova', 'platform', 'remove', 'ios', '--nosave']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'remove',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(false);
it('Test #037 : (remove) platform is not removed when --nosave is passed in', () => {
return cli(['node', 'cordova', 'platform', 'remove', 'ios', '--nosave']).then(() => {
expect(cordova.platform).toHaveBeenCalledWith(
'remove',
['ios'],
jasmine.any(Object)
);
const opts = cordova.platform.calls.argsFor(0)[2];
expect(opts.save).toBe(false);
});
});
});
});

describe('config', () => {
let clirevert, confrevert, editorArgs, confHolder;
const cordovaConfig = {};

const confMock = {
set (key, value) {
cordovaConfig[key] = value;
},
del (key) {
delete cordovaConfig[key];
},
path () {
confHolder = 'Pathcalled';
return 'some/path/cordova-config.json';
},
get (key) {
confHolder = cordovaConfig[key];
return cordovaConfig[key];
}
};

beforeEach(() => {
clirevert = cli.__set__('editor', (path1, cb) => {
editorArgs = path1();
cb();
});
describe('config', () => {
let clirevert, confrevert, editorArgs, confHolder;
const cordovaConfig = {};

const confMock = {
set (key, value) {
cordovaConfig[key] = value;
},
del (key) {
delete cordovaConfig[key];
},
path () {
confHolder = 'Pathcalled';
return 'some/path/cordova-config.json';
},
get (key) {
confHolder = cordovaConfig[key];
return cordovaConfig[key];
}
};

confrevert = cli.__set__('conf', confMock);
logger.setLevel('error');
// spyOn(console, 'log');
});
beforeEach(() => {
clirevert = cli.__set__('editor', (path1, cb) => {
editorArgs = path1();
cb();
});

afterEach(() => {
clirevert();
confrevert();
confHolder = undefined;
});
confrevert = cli.__set__('conf', confMock);
logger.setLevel('error');
// spyOn(console, 'log');
});

it('Test#042 : config set autosave is called with true', () => {
return cli(['node', 'cordova', 'config', 'set', 'autosave', 'true', '--silent']).then(() => {
expect(cordovaConfig.autosave).toBe('true');
afterEach(() => {
clirevert();
confrevert();
confHolder = undefined;
});
});

it('Test#043 : config delete autosave is called', () => {
return cli(['node', 'cordova', 'config', 'delete', 'autosave']).then(() => {
expect(cordovaConfig.autosave).toBeUndefined();
it('Test#042 : config set autosave is called with true', () => {
return cli(['node', 'cordova', 'config', 'set', 'autosave', 'true', '--silent']).then(() => {
expect(cordovaConfig.autosave).toBe('true');
});
});
});

it('Test#044 : config set is called even without value, defaults to true', () => {
return cli(['node', 'cordova', 'config', 'set', 'autosave']).then(() => {
expect(cordovaConfig.autosave).toBe(true);
it('Test#043 : config delete autosave is called', () => {
return cli(['node', 'cordova', 'config', 'delete', 'autosave']).then(() => {
expect(cordovaConfig.autosave).toBeUndefined();
});
});
});

it('Test #045 : config get is called', () => {
return cli(['node', 'cordova', 'config', 'get', 'autosave']).then(() => {
expect(confHolder).toBe(true);
it('Test#044 : config set is called even without value, defaults to true', () => {
return cli(['node', 'cordova', 'config', 'set', 'autosave']).then(() => {
expect(cordovaConfig.autosave).toBe(true);
});
});
});

it('Test #046 : config edit is called', () => {
return cli(['node', 'cordova', 'config', 'edit']).then(() => {
expect(path.basename(editorArgs)).toEqual('cordova-config.json');
expect(confHolder).toEqual('Pathcalled');
it('Test #045 : config get is called', () => {
return cli(['node', 'cordova', 'config', 'get', 'autosave']).then(() => {
expect(confHolder).toBe(true);
});
});
});

it('Test #047 : config ls is called', () => {
spyOn(fs, 'readFile').and.callFake((confPath, cb) => {
confHolder = confPath();
it('Test #046 : config edit is called', () => {
return cli(['node', 'cordova', 'config', 'edit']).then(() => {
expect(path.basename(editorArgs)).toEqual('cordova-config.json');
expect(confHolder).toEqual('Pathcalled');
});
});

return cli(['node', 'cordova', 'config', 'ls']).then(() => {
expect(path.basename(confHolder)).toEqual('cordova-config.json');
it('Test #047 : config ls is called', () => {
spyOn(fs, 'readFile').and.callFake((confPath, cb) => {
confHolder = confPath();
});

return cli(['node', 'cordova', 'config', 'ls']).then(() => {
expect(path.basename(confHolder)).toEqual('cordova-config.json');
});
});
});

});
});

0 comments on commit f8ed27c

Please # to comment.