Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hangs during rustfmt when saving #17

Closed
antifuchs opened this issue Oct 27, 2018 · 3 comments
Closed

hangs during rustfmt when saving #17

antifuchs opened this issue Oct 27, 2018 · 3 comments

Comments

@antifuchs
Copy link

I'm just trying out rustic, and it feels really cool! Unfortunately, I'm running into a weird problem: When I save a rust file with rustic-format-on-save set to t, emacs hangs. I used toggle-debug-on-quit, used C-x C-s, waited a bit and then hit C-g; I got this backtrace:

Debugger entered--Lisp error: (quit)
  rustic-before-save-hook()
  run-hooks(before-save-hook)
  basic-save-buffer(t)
  save-buffer(1)
  funcall-interactively(save-buffer 1)
  call-interactively(save-buffer nil nil)
  command-execute(save-buffer)

I suspect this is an interaction with something else on the before-save-hook, so here's what's on there:

(eglot--signal-textDocument/willSave rustic-before-save-hook t)

I set rustic-rls-pkg to eglot, could that be related?

@antifuchs
Copy link
Author

(Update: I tried setting rustic-rls-pkg to lsp-mode, installed lsp-mode and restarted emacs; saving still hangs).

@brotzeit
Copy link
Owner

brotzeit commented Oct 27, 2018

Did you try it with a minimal config ? I mean only rustic + eglot/lsp-mode.

@brotzeit
Copy link
Owner

@antifuchs I made some changes and hopefully it works now. If not, please open another issue. Thanks for the bug report.

psibi added a commit that referenced this issue May 5, 2024
Improve minibuffer entry population for build and clippy
tarsius pushed a commit to emacsmirror/rustic that referenced this issue Jun 30, 2024
Use xterm-color-names in rustic compilation buffers
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants