-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: drop support for Python 3.8 #1200
Conversation
Reviewer's Guide by SourceryThis pull request removes Python 3.8 support from the CI workflow by removing it from the test matrix. The change is implemented through a simple modification to the GitHub Actions workflow configuration. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @browniebroke - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please provide the rationale for dropping Python 3.8 support.
- This change needs to be reflected in all relevant files (setup.py, documentation, etc.) to maintain consistency in version support declaration.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
=======================================
Coverage 98.72% 98.73%
=======================================
Files 30 30
Lines 1021 1026 +5
Branches 166 166
=======================================
+ Hits 1008 1013 +5
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Committed via https://github.com/asottile/all-repos
Summary by Sourcery
CI: