Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: drop support for Python 3.8 #1200

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

browniebroke
Copy link
Owner

@browniebroke browniebroke commented Oct 31, 2024

Committed via https://github.com/asottile/all-repos

Summary by Sourcery

CI:

  • Remove Python 3.8 from the CI testing matrix.

Copy link
Contributor

sourcery-ai bot commented Oct 31, 2024

Reviewer's Guide by Sourcery

This pull request removes Python 3.8 support from the CI workflow by removing it from the test matrix. The change is implemented through a simple modification to the GitHub Actions workflow configuration.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Remove Python 3.8 from the CI test matrix
  • Remove Python 3.8 from the python-version matrix array
  • Maintain support for Python versions 3.9, 3.10, and 3.11
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @browniebroke - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide the rationale for dropping Python 3.8 support.
  • This change needs to be reflected in all relevant files (setup.py, documentation, etc.) to maintain consistency in version support declaration.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (36d1f59) to head (9fcead5).
Report is 85 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files          30       30           
  Lines        1021     1026    +5     
  Branches      166      166           
=======================================
+ Hits         1008     1013    +5     
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@browniebroke browniebroke merged commit 513eb8a into main Oct 31, 2024
22 checks passed
@browniebroke browniebroke deleted the all-repos_autofix_feat/drop-python-3.8 branch October 31, 2024 19:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant