streamline types #222
Merged
streamline types #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be34014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks so much for all your work here! Generally LGTM; we have a few other things in flight that I want to get to before merging this, but we'll be on it shortly. In the meantime please add a changeset with |
|
Ofc! Sure I'll do that |
kamath
approved these changes
Nov 26, 2024
This reverts commit 1963130.
This was referenced Nov 26, 2024
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
Type definitions are currently unorganized, this makes code more readable and easier to maintain. (Addresses #185)
what changed
Wrote type definitions for all
Stagehandclass methods and moved existing type definitions to a newtypesfolder.test plan
Use existing evals.