move act/extract/observe -> page #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0459dba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* need to actually move to act to page now * move act -> page * fix e2e * fix tests * readme * changeset * package json and changeset * don't fail on combo evals
* move act evals to stagehand.page * add basic act and make act necessary in type
* move act evals to stagehand.page * add basic act and make act necessary in type * move extract and observe * example * changeset
* add docs, move scoring functions to scoring.ts, move experiment naming to utils.ts * add initStagehand.ts * break up index.evals.ts and utils into smaller files * export LogLineEval * typing * follow StagehandConfig pattern * choose api key based on model name * Use CI on v2 branch * branch * stagehand.page tests * dont run on BB * prettier * pls dont fail * headless --------- Co-authored-by: Anirudh Kamath <github@kamath.io>
* add extract evals for stagehand.page * fix typign * smh i didn't actually run extract
* change stagehand.observe to stagehand.page.observe in evals * changeset
sameelarif
reviewed
Dec 24, 2024
| ObserveResult, | ||
| } from "./stagehand"; | ||
| import type { z } from "zod"; | ||
| export interface Page extends PlaywrightPage { |
There was a problem hiding this comment.
should be named StagehandPage imo to reduce potential confusion
sameelarif
approved these changes
Dec 24, 2024
* add docs, move scoring functions to scoring.ts, move experiment naming to utils.ts * add initStagehand.ts * break up index.evals.ts and utils into smaller files * export LogLineEval * typing * follow StagehandConfig pattern * choose api key based on model name * Use CI on v2 branch * branch * BrowserContext tests * file path --------- Co-authored-by: Anirudh Kamath <github@kamath.io>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
We want act/extract/observe to be at the page level to give us the ability to modify the Playwright page as needed. act/extract/observe at the stagehand level will be deleted in v2, but it's deprecated as of now
what changed
stagehand.page, forwardstagehand.act/extract/observeintostagehand.page, and deprecate act/extract/observe at the stagehand level.test plan