Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor LLM Types #383

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Refactor LLM Types #383

merged 5 commits into from
Jan 7, 2025

Conversation

sameelarif
Copy link
Collaborator

why

We want to reduce dependency on OpenAI types as we continue to add more models

what changed

Added unifying types for LLM inputs and outputs

test plan

Existing evals

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 247a844

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sameelarif sameelarif requested a review from kamath January 7, 2025 01:45
@sameelarif sameelarif added enhancement New feature or request combination These changes affect multiple Stagehand functions labels Jan 7, 2025
Copy link
Contributor

@kamath kamath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg lfg lfg lfg 🧹 great cleanup

@@ -39,7 +35,7 @@ export class AnthropicClient extends LLMClient {
this.clientOptions = clientOptions;
}

async createChatCompletion<T = AnthropicTransformedResponse>(
async createChatCompletion<T = LLMResponse>(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally 🙏🙏🙏🙏🙏

@sameelarif sameelarif merged commit a77efcc into main Jan 7, 2025
12 of 18 checks passed
@sameelarif sameelarif deleted the sameel/refactor-llm-types branch January 7, 2025 02:23
@github-actions github-actions bot mentioned this pull request Jan 6, 2025
@kamath kamath mentioned this pull request Jan 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
combination These changes affect multiple Stagehand functions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants