Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Patch for type builds #422

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Patch for type builds #422

merged 2 commits into from
Jan 21, 2025

Conversation

miguelg719
Copy link
Collaborator

why

Solving a compile error on observe when calling await inside evaluate() functions

what changed

const evalResult = await this.stagehand.page.evaluate(async () => { const result = await window.processAllOfDom(); return result; });

is now

const evalResult = await this.stagehand.page.evaluate(() => { return window.processAllOfDom().then((result) => result); });

test plan

  • run on observe evals locally
  • run on ci observe evals

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 3ac2bd2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@browserbasehq/stagehand Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@miguelg719 miguelg719 requested a review from kamath January 21, 2025 18:12
@seanmcguire12 seanmcguire12 added the observe These changes pertain to the observe function label Jan 21, 2025
@miguelg719 miguelg719 merged commit a2878d0 into main Jan 21, 2025
10 checks passed
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
observe These changes pertain to the observe function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants