Adds type definitions for typescript users #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think @types is preferred tbh, but, this is an ACK from me otherwise |
|
is there a away we could grab the version in from node somehow ? |
|
@calvinmetcalf wrong PR? |
|
no, the typings for node |
|
@calvinmetcalf not sure I 100% understand. That is what I am trying to do here. I could take it a step further and make this package dependant on @types/node |
EthanGD
approved these changes
Jan 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another option (IMO less desirable) would be to publish them to the @types organization. If that is preferred, just let me know!