This repository was archived by the owner on May 27, 2019. It is now read-only.
Use store path as hover title for store badge #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximbaz
reviewed
Apr 3, 2018
| var name = login; | ||
| var i; | ||
| if ((i = login.indexOf(":"))) { | ||
| if (searchSettings && searchSettings.customStores.length > 1) { | ||
| store = login.substr(0, i); | ||
| searchSettings.customStores.map(function(customStore) { |
There was a problem hiding this comment.
Oops - that was a mistake. Intention was forEach. I think I must have been looking at map elsewhere, and typed it accidentally.
No real functional impact using it here though - so we can leave it as-is - but would you like me to change it for clarity?
There was a problem hiding this comment.
Or I guess I could have used a for (i in searchSettings.customStores) { loop too.
There was a problem hiding this comment.
I'll maybe change to forEach next time I need to do some changes in that file, as you said there is no functional impact anyway 😉
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hovering over the store name badge in multi-store mode, display the path to that store.