feat(collator): add seqno to rand seed #306
Open
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmaGMan
requested changes
Sep 12, 2024
Rexagon
reviewed
Sep 12, 2024
collator/src/collator/do_collate.rs
Outdated
| @@ -76,7 +76,12 @@ impl CollatorStdImpl { | |||
| // TODO: need to generate unique for each block | |||
| // generate seed from the chain_time from the anchor | |||
| let hash_bytes = sha2::Sha256::digest(next_chain_time.to_be_bytes()); | |||
| let rand_seed = HashBytes::from_slice(hash_bytes.as_slice()); | |||
| let seqno = working_state.next_block_id_short.seqno.to_be_bytes(); | |||
There was a problem hiding this comment.
Compute a hash from (next_chain_time, seqno, ...other_things) instead of combining values with hash. It must not lose any entropy! Here the last bytes are just a number => less entropy than hash
There was a problem hiding this comment.
You can define a new struct with TlWrite derive and use it as a source for hasher
serejkaaa512
force-pushed
the
feature/rand-seed
branch
2 times, most recently
from
fc2c1d6 to
77c830c
Compare
SmaGMan
approved these changes
Sep 12, 2024
serejkaaa512
force-pushed
the
feature/rand-seed
branch
from
77c830c to
150d565
Compare
serejkaaa512
force-pushed
the
feature/rand-seed
branch
from
150d565 to
f2ea933
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.