fix(validator): session signatures storage #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
2 times, most recently
from
24eeec1 to
9d624fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
==========================================
- Coverage 43.03% 43.00% -0.03%
==========================================
Files 262 262
Lines 45556 45554 -2
Branches 45556 45554 -2
==========================================
- Hits 19603 19591 -12
- Misses 24898 24905 +7
- Partials 1055 1058 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
from
9d624fb to
c2051a4
Compare
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
2 times, most recently
from
d15519c to
161a241
Compare
drmick
changed the title
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
from
161a241 to
e0f45af
Compare
Rexagon
requested changes
Nov 12, 2024
| .build(block_id, state.weight_threshold); | ||
| let block_signatures = { | ||
| match &cached { | ||
| Some(cached) => self.reuse_signatures(block_id, cached.clone()).await, |
There was a problem hiding this comment.
entry lives across the await here, it can deadlock
| let cached = state | ||
| .cached_signatures | ||
| .peek(&block_id.seqno, &scc::ebr::Guard::new()) | ||
| .map(Arc::clone); | ||
| .remove(&block_id.seqno) |
There was a problem hiding this comment.
We were intentionally overlapping cached_signatures item lifetime with block signatures lifetime. You can't delete a value here since it can miss some signatures
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
from
1a6b32e to
e5c8645
Compare
SmaGMan
reviewed
Nov 14, 2024
SmaGMan
requested changes
Nov 14, 2024
drmick
force-pushed
the
ref/validator-session-signature-storage
branch
from
e5c8645 to
34cc696
Compare
SmaGMan
approved these changes
Nov 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.