Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/consensus/ restart #507

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

Mododo
Copy link
Member

@Mododo Mododo commented Dec 25, 2024

No description provided.

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 18.43449% with 1438 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (19795d3) to head (8471d94).

Files with missing lines Patch % Lines
consensus/src/models/point_status.rs 5.53% 256 Missing ⚠️
consensus/src/dag/dag_point_future.rs 15.95% 235 Missing and 2 partials ⚠️
consensus/src/dag/dag_location.rs 27.20% 176 Missing and 6 partials ⚠️
consensus/src/dag/verifier.rs 38.53% 122 Missing and 4 partials ⚠️
consensus/src/effects/store.rs 1.65% 118 Missing and 1 partial ⚠️
consensus/src/engine/impl_.rs 0.00% 95 Missing ⚠️
consensus/src/models/dag_point.rs 15.17% 95 Missing ⚠️
storage/src/store/mempool/point_status.rs 0.00% 93 Missing ⚠️
consensus/src/dag/dag_round.rs 13.33% 52 Missing ⚠️
consensus/src/dag/producer.rs 0.00% 52 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   44.21%   43.74%   -0.48%     
==========================================
  Files         269      270       +1     
  Lines       47585    48296     +711     
  Branches    47585    48296     +711     
==========================================
+ Hits        21041    21127      +86     
- Misses      25461    26084     +623     
- Partials     1083     1085       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mododo Mododo force-pushed the fix/consensus/reproducible-restart branch 2 times, most recently from d2ab1a8 to 9d337a0 Compare December 26, 2024 21:39
logs and owned `Bytes` for later
restart with empty DB will be done the other way
fix: leader did not produce point at restart
fixes potential race when point is accounted in threshold but not yet resolved in DAG
* remove potential mutual `.await` of cloned futures in equivocation check
* FIXME: sign or reject location when point can no longer be referenced
fixes sign or reject issue from previous commit
* split download and restore futures
* do not produce alternative point if db was removed
@Mododo Mododo force-pushed the fix/consensus/reproducible-restart branch from 9d337a0 to 8471d94 Compare December 27, 2024 13:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant