Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Don't steal focus after detecting file changes and deletions #139

Merged
merged 2 commits into from
Jan 5, 2017

Conversation

darahak
Copy link
Contributor

@darahak darahak commented Dec 28, 2016

Fixes #132.

Now the dialogs are displayed only when the app gets the focus back.

Also because it is an async matter now, when a dialog is about to be displayed, it checks if the file still exists or not.
For example, if the file is modified by a third-party, and then deleted, only the "Delete" dialog will show up.


Before submitting your PR please make sure:

  • You worked on the develop branch (or any other branch which was forked from develop),
  • Your PR is not targeting the master branch,
  • You tested your code and it works.

Thank you!

@darahak darahak changed the title Detect file changes and deletions, without stealing focus Don't steal focus after detecting file changes and deletions Dec 29, 2016
@brrd brrd merged commit b808362 into brrd:develop Jan 5, 2017
@brrd
Copy link
Owner

brrd commented Jan 5, 2017

This is perfect now! 👍

@darahak darahak deleted the auto-reload-on-focus branch January 5, 2017 22:27
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants