use metal::less as default ordering for metal::sort #101
Conversation
ecrypa
force-pushed
the
feature/default-comp-for-sort
branch
from
25b406f to
ffcdd58
Compare
ecrypa
force-pushed
the
feature/default-comp-for-sort
branch
2 times, most recently
from
111426c to
3c0c2af
Compare
There was a problem hiding this comment.
What can we do now?
Worst case I think we should define it in terms of a variadic pack only under METAL_WORKAROUND, which means only MSVC and really old GCC would see a variadic pack, in particular docs would show the right thing.
Having a slightly different behavior for broken compilers is still better than either not having the feature at all or exposing the variadic pack on all compilers.
| using sort = detail::call< | ||
| detail::_sort<lbd>::template type, | ||
| detail::_sort<lbd...>::template type, |
There was a problem hiding this comment.
We do already have default template arguments on aliases, so there's hope.
There was a problem hiding this comment.
Do you mind if I open a couple of PRs in order to test different versions? Or should I prefer godbolt.org in order to reduce the load of your CI setup?
There was a problem hiding this comment.
I tried, but I think it is not worth any more effort. I vote for the workaround.
ecrypa
force-pushed
the
feature/default-comp-for-sort
branch
from
06680ac to
2eaf8c9
Compare
see #73 (comment)