Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix README references to "cookbook_name" #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix README references to "cookbook_name" #15

wants to merge 1 commit into from

Conversation

markjreed
Copy link

The README refers to cookbook_name as an attribute of a resource specifying the location of the associated file, but that is incorrect; the attribute is simply cookbook. There is a cookbook_name method, but it just returns the name of the cookbook containing the current recipe.

@hltbra
Copy link
Contributor

hltbra commented Oct 30, 2013

I think that's not true, @markjreed. @bryanwb overrode Chef::Recipe#cookbook_name: 6e828cd#diff-11f3abe9c672639ddca46a2698e820e5R37

Did you run chef-rewind and get any problem because of it, or did you catch it just by reading README.md?

@markjreed
Copy link
Author

Well, then the bug is different, but still there. :) Now you're hiding the
upstream 'cookbook_name' method, making it unavailable inside the
definition block of a rewound resource.

Why would you call it 'cookbook_name' inside chef-edit instead of just
using the existing 'cookbook' attribute that cookbook_file and template
resources already have?

On Wed, Oct 30, 2013 at 10:49 AM, Hugo Lopes Tavares <
notifications@github.com> wrote:

I think that's not true, @markjreed https://github.com/markjreed.
@bryanwb https://github.com/bryanwb overrode Chef::Recipe#cookbook_name:
6e828cd#diff-11f3abe9c672639ddca46a2698e820e5R376e828cd#diff-11f3abe9c672639ddca46a2698e820e5R37

Did you run chef-rewind and get any problem because of it, or did you
catch it just by reading README.md?


Reply to this email directly or view it on GitHubhttps://github.com//pull/15#issuecomment-27395330
.

Mark J. Reed markjreed@gmail.com

@thommay
Copy link
Collaborator

thommay commented Dec 16, 2014

I'm not sure there's a way of sensibly fixing this now - demunging cookbook_name is just going to break existing rewind users

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants