Add the ability to set a proxy #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon-sunset
reviewed
Jun 6, 2023
neon-sunset
approved these changes
Jun 6, 2023
neon-sunset
reviewed
Jun 6, 2023
| @@ -68,7 +68,8 @@ public async Task<BingChatConversation> CreateConversation() | |||
| if (cookies.Count == 0) | |||
| cookies.Add(new Uri("https://www.bing.com"), new Cookie("_U", Utils.GenerateRandomHexString())); | |||
|
|
|||
| using var handler = new HttpClientHandler { CookieContainer = cookies }; | |||
| using var handler = new HttpClientHandler | |||
| { CookieContainer = cookies, Proxy = _options.Proxy, UseProxy = _options.Proxy != null }; | |||
There was a problem hiding this comment.
By the way, according to documentation, you do not need to set UseProxy property because it is true by default and this change would alter the behavior.
Ref: https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.useproxy
|
Also, I just realized that this PR would not work as is because it is also necessary to set proxy to SignalR connection factory. See https://github.com/bsdayo/BingChat/blob/main/src/BingChat/BingChatConversation.cs#L21 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue #20 that I have been experiencing myself. Seems Bing has a limit of 300 conversations a day and will block your IP if you reach that limit. Changing IP of the request via a proxy fixes this and avoids routing the whole system which may be problematic.
Let me know if you think this should be done a different way, I tried to follow the projects style :)