Update Details #137
Open
Update Details #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenearley
reviewed
Apr 29, 2021
| @@ -10,7 +10,7 @@ class Details extends React.Component { | |||
| state = { loading: true, showModal: false }; | |||
| componentDidMount() { | |||
| pet | |||
| .animal(this.props.id) | |||
| .animal(parseInt(this.props.id)) | |||
There was a problem hiding this comment.
Don't forget the radix. You want to make sure that it gets parse to base 10.
parseInt(this.props.id, 10)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt
And actually in this case, I believe it would be more appropriate to use Number()
Number(this.props.id)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
There was a problem hiding this comment.
What you say sounds good. @btholt What do you think ?
In case you decide by Number I modify it
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear, as an attachment in the problem #136 when you throw this error, the way I found on the internet to solve it is with parseInt.
I am looking forward to your response.
#136