Fix cursor-at for close tokens #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
reviewed
Feb 11, 2025
emcfarlane
reviewed
Feb 11, 2025
emcfarlane
approved these changes
Feb 11, 2025
mcy
approved these changes
Feb 11, 2025
mcy
pushed a commit
that referenced
this pull request
Feb 12, 2025
Since open/close tokens are fused, when we set the `idx` for `NewCursorAt` for close tokens, we need to use the offset to set it to the open token.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since open/close tokens are fused, when we set the
idxforNewCursorAtfor close tokens, we need to use the offset toset it to the open token.