Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Get image from asset #4

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Get image from asset #4

merged 1 commit into from
Dec 2, 2015

Conversation

DreamingInBinary
Copy link
Contributor

No description provided.

@DreamingInBinary
Copy link
Contributor Author

If this feels okay to you @ay8s I'll go ahead and merge this in. Supporting PHAsset as an image source seemed to be the best way to support peeking and popping when the images are shown in a collection view. The thumbnails do us no good, and this will give us the full res image when peeking, and when fully popped 👍

@ay8s
Copy link
Member

ay8s commented Dec 2, 2015

👍

DreamingInBinary pushed a commit that referenced this pull request Dec 2, 2015
@DreamingInBinary DreamingInBinary merged commit bd37da5 into master Dec 2, 2015
@DreamingInBinary DreamingInBinary deleted the task/support-PHAsset branch December 2, 2015 21:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants