Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAT-5618] refactor: Source map CLI now adds the path suffix automatically #353

Conversation

bengourley
Copy link
Contributor

Goal

One last change to this task – the source map lib now determines the correct path.

Testing

Updated existing tests. Will be tested via e2e RN CLI tests when they land.

@bengourley bengourley force-pushed the road-945/source-map-lib-add-endpoint-path branch from 1cadc79 to 623a113 Compare December 16, 2020 17:08
@bengourley bengourley force-pushed the road-945/source-map-lib-add-endpoint-path branch from 623a113 to 9fdaff6 Compare December 17, 2020 08:59
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengourley bengourley force-pushed the road-945/source-map-lib-add-endpoint-path branch from f1dfc00 to 155a60d Compare December 18, 2020 10:04
@bengourley bengourley merged commit 7c9f039 into integration/road-945-rn-sourcemaps Dec 18, 2020
@bengourley bengourley deleted the road-945/source-map-lib-add-endpoint-path branch December 18, 2020 15:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants