Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAT-5618] RN-CLI: Let source map lib add the path #1207

Merged
merged 1 commit into from
Dec 17, 2020
Merged

[PLAT-5618] RN-CLI: Let source map lib add the path #1207

merged 1 commit into from
Dec 17, 2020

Conversation

bengourley
Copy link
Contributor

Goal

One last change to this shell script – the source map lib now determines the correct path.

Testing

Tested manually. Will also be tested via e2e RN CLI tests when they land.

nickdowell
nickdowell approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@nickdowell nickdowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice; that simplifies things 👍

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 1444208

@bengourley bengourley merged commit 705a9dc into integration/rn-cli Dec 17, 2020
@bengourley bengourley deleted the rn-cli/endpoint-arg-path branch December 17, 2020 09:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nickdowell nickdowell nickdowell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @nickdowell