Convert @bugsnag/core/lib/metadata-delegate to TypeScript #2437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiiaSvietlova
changed the title
gingerbenw
reviewed
May 14, 2025
Comment on lines
4
to
6
| add: (state: { [key: string]: any }, section: string, keyOrObj?: any, maybeVal?: any) => any | ||
| get: (state: { [key: string]: any }, section: string, key?: any) => any | ||
| clear: (state: { [key: string]: any }, section: string, key?: any) => any |
There was a problem hiding this comment.
can we just double check what these instances of any should be? for example key looks like it should only be string or undefined according to the get function, and section should probably be unknown
There was a problem hiding this comment.
I checked it's usage in other parts of the code. So we use metadataDelegate in client.ts and event.ts. Since these files are already converted to TS, I took them as a source of possible types.
Based on what you're wrote I will change the type of key to string | undefined and in client.ts too.
But the section is always string 🤔
gingerbenw
reviewed
May 21, 2025
| interface MetadataDelegate { | ||
| add: (state: { [key: string]: any }, section: string, keyOrObj?: object | string, maybeVal?: any) => any | ||
| get: (state: { [key: string]: any }, section: string, key?: string | undefined) => any | ||
| clear: (state: { [key: string]: any }, section: string, key?: string | undefined) => any |
There was a problem hiding this comment.
the question mark in key?: string also allows for undefined so that's probably fine as it was.
gingerbenw
previously approved these changes
May 21, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Convert @bugsnag/core/lib/metadata-delegate to TypeScript
Testing
Covered by existing end to end and unit tests