Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Support --overwrite and --no-overwrite everywhere #66

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

bengourley
Copy link
Contributor

Goal

For tools using this module under the hood, remove the need for logic to determine whether --overwrite or --no-overwrite are required and simply allow both everywhere (even if they are the default behaviour).

Previously if --overwrite was supplied to the upload-react-native command, it would error because the default was to overwrite, and it only supported the --no-overwrite option.

@bengourley bengourley requested a review from imjoehaines June 16, 2021 09:39
@bengourley bengourley merged commit 6d8338e into next Jun 16, 2021
@bengourley bengourley deleted the bengourley/no-overwrite-opt branch June 16, 2021 10:49
@djskinner djskinner mentioned this pull request Jul 5, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants